Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish IPIPs to specs.ipfs.tech #385

Merged
merged 4 commits into from
May 9, 2023
Merged

Publish IPIPs to specs.ipfs.tech #385

merged 4 commits into from
May 9, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 17, 2023 •
edited
Loading

Based on #394.

A preview of what moving the IPIPs can look like. Nice things to get:

@hacdias hacdias self-assigned this Mar 17, 2023
@hacdias

This comment was marked as outdated.

Sign in to view
@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 5 times, most recently from 663c99e to ac2ba02 Compare March 27, 2023 06:49
darobin
darobin reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@darobin darobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mostly questions and general comments, nothing on the critical path.

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/ipips/index.html Outdated Show resolved Hide resolved
src/ipips/ipip-0001.md Show resolved Hide resolved
src/ipips/ipip-0001.md Outdated Show resolved Hide resolved
src/ipips/ipip-0002.md Show resolved Hide resolved
Base automatically changed from try-ipseity to main March 29, 2023 19:44
@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 3 times, most recently from 6aaafa9 to 8d24f99 Compare March 30, 2023 08:39
@hacdias hacdias mentioned this pull request Mar 30, 2023
Merged
@hacdias hacdias marked this pull request as ready for review March 30, 2023 09:05
@hacdias hacdias requested a review from a team as a code owner March 30, 2023 09:05
@hacdias
Copy link
Member Author

hacdias commented Mar 30, 2023

I marked it as ready for review as I think most things are "ready". We just have to merge ipfs/spec-generator#6 and settle on how we want to style the IPIPs.

@hacdias hacdias mentioned this pull request Mar 30, 2023
Merged
7 tasks
@hacdias hacdias changed the base branch from main to fix/spacing-mobile-header March 30, 2023 11:24
Base automatically changed from fix/spacing-mobile-header to main March 30, 2023 11:32
@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 5 times, most recently from 4d82ff7 to c264a3c Compare April 4, 2023 14:53
@hacdias
Copy link
Member Author

hacdias commented Apr 4, 2023

This is how IPIPs look now. Just have to add a maturity: proposal:

bafybeid3kgm7r5slbo6tgvqegp2j4zyjdgid2oabzoxx25bld55xnnp32m on fleek co_ipips_ipip-0337_

@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 3 times, most recently from fbc1a53 to 94e0c46 Compare April 7, 2023 08:28
lidel
lidel reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias @darobin do either of you needs this to land this week before Governance track and related talks?
If so, lmk, I can merge and we can fix things later.
If not critical, i am ok with keeping this open, and getting back to it after we are done with IPFS Thing.

src/_includes/specs/ipips.html Outdated Show resolved Hide resolved
src/ipips/ipip-0002.md Show resolved Hide resolved
src/ipips/ipip-0002.md Outdated Show resolved Hide resolved
@hacdias
Copy link
Member Author

hacdias commented Apr 16, 2023

@lidel not critical for our presentation, so we can push it back for next week.

@lidel lidel mentioned this pull request Apr 17, 2023
Merged
@hacdias hacdias mentioned this pull request Apr 19, 2023
Closed
@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 2 times, most recently from a765720 to 178c9f3 Compare April 24, 2023 08:30
@hacdias hacdias mentioned this pull request May 4, 2023
Draft
4 tasks
@hacdias hacdias requested review from lidel and darobin May 5, 2023 15:19
darobin
darobin reviewed May 5, 2023
View reviewed changes
src/css/specs.css
display: block;
background: url('/img/watermark-ratified.svg');
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this use background-image on body? It would be less hacky.

darobin
darobin approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@darobin darobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do the watermark differently, but I would rather ship now and fix later than hold up just for that.

@hacdias
Copy link
Member Author

hacdias commented May 5, 2023 •
edited
Loading

@darobin i don't like the way I did the watermakrs either. Suggestions?

@hacdias hacdias mentioned this pull request May 8, 2023
Merged
@hacdias hacdias force-pushed the specs.ipfs.tech-ipips branch 2 times, most recently from e09e1b4 to f8194ae Compare May 8, 2023 16:10
lidel
lidel approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can fix cosmethics in follow-up.

Merging to unblock IPIP work in #402 using the new template

@lidel lidel merged commit fd24159 into main May 9, 2023
@lidel lidel deleted the specs.ipfs.tech-ipips branch May 9, 2023 13:46
@lidel lidel mentioned this pull request May 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@darobin darobin darobin approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @darobin @lidel